Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanjgupt/onlineproblem #55

Merged
merged 25 commits into from
May 10, 2021
Merged

Conversation

sanjgupt
Copy link
Contributor

@sanjgupt sanjgupt commented May 3, 2021

Create online problem for problem reuse and add client side warning etc.
The design diagram can be found here:
https://dev.azure.com/ms-quantum/Quantum%20Program/_wiki/wikis/Quantum-OKRs.wiki/2009/Problem-reuse-behavior

Support for streaming problem will be in the follow up PR

@sanjgupt sanjgupt requested review from vxfield and adelebai May 3, 2021 19:21
@adelebai
Copy link
Contributor

adelebai commented May 5, 2021

Looks good to me. I'm surprised the download() requires workspace auth - I was assuming that customers would be calling it with the full uri (including access token), but in case they aren't I think the current approach works too.

@sanjgupt
Copy link
Contributor Author

sanjgupt commented May 6, 2021

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@sanjgupt
Copy link
Contributor Author

sanjgupt commented May 6, 2021

/azp list

@azure-pipelines
Copy link

No pipelines found for this repository.

@cgranade
Copy link
Contributor

cgranade commented May 7, 2021

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vxfield
Copy link
Member

vxfield commented May 7, 2021

Hi @sanjgupt, can you revert your changes to the _client folder?
Those files should not be changed manually (even if it's for code styling issues) as they are auto-generated and can be replaced at any time.
#54 will soon update the _client folder anyway.

@guenp
Copy link
Contributor

guenp commented May 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sanjgupt
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sanjgupt sanjgupt enabled auto-merge (squash) May 10, 2021 18:12
@anpaz
Copy link
Member

anpaz commented May 10, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sanjgupt sanjgupt merged commit 184d20e into microsoft:main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants